Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/psm3: remove uses of "psm2" #7797

Open
BrendanCunningham opened this issue May 31, 2022 · 0 comments
Open

prov/psm3: remove uses of "psm2" #7797

BrendanCunningham opened this issue May 31, 2022 · 0 comments
Assignees

Comments

@BrendanCunningham
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In the latest libfabric/main source code (cmt dabd772, 26 May 2022), prov/psm3 uses “psm2” (case-insensitive) in the following ways:

  • Header names, e.g. “psm2.h”, “psm2_am.h”.
  • Type names, e.g. “psm2_error_t”, “psm2_ep_t”.
  • Defines, e.g. “PSM2_OK”, “PSM2_INTERNAL_ERR”.
  • At least two function names, both static and non-static, e.g. extern psm2_get_gpu_bars(), static psm2_check_phys_addr().

This creates false hits when searching from “PSM2” (i.e. not under prov/psm2) in the libfabric code base and presents multiple-definition and false-linking risks, a la #7757.

Describe the solution you'd like
Files under prov/psm3 renamed from "psm2*" to "psm3*". Occurrences of "psm2" (case-insensitive) in definition names replaced with psm3 or any other non-conflicting identifier. Particularly for any definitions that have global linkage or may end included in compilation units that do not directly include any psm3 headers.

Describe alternatives you've considered
None.

Additional context
Did not check for or consider occurrences of "psm2" in comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants