Skip to content

Commit

Permalink
NUMA for 9 threads or more
Browse files Browse the repository at this point in the history
Enable numa machinery only for STRICTLY MORE than 8 threads. Reason for this
change is that nowadays SMP tests are always done with 8 threads. That is a
problem for multi-socket Windows machines running on fishtest.

No functional change
  • Loading branch information
CoffeeOne authored and snicolet committed Oct 25, 2018
1 parent 9fff272 commit bc3b148
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ Pascal Romaret
Pasquale Pigazzini (ppigazzini)
Patrick Jansen (mibere)
pellanda
Peter Zsifkovits (CoffeeOne)
Ralph Stößer (Ralph Stoesser)
Raminder Singh
renouve
Expand Down
2 changes: 1 addition & 1 deletion src/thread.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void Thread::idle_loop() {
// some Windows NUMA hardware, for instance in fishtest. To make it simple,
// just check if running threads are below a threshold, in this case all this
// NUMA machinery is not needed.
if (Options["Threads"] >= 8)
if (Options["Threads"] > 8)
WinProcGroup::bindThisThread(idx);

while (true)
Expand Down
2 changes: 1 addition & 1 deletion src/tt.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ void TranspositionTable::clear() {
threads.push_back(std::thread([this, idx]() {

// Thread binding gives faster search on systems with a first-touch policy
if (Options["Threads"] >= 8)
if (Options["Threads"] > 8)
WinProcGroup::bindThisThread(idx);

// Each thread will zero its part of the hash table
Expand Down

0 comments on commit bc3b148

Please sign in to comment.