Phototonic slowdowns

[ghost]

Since the Debian 9 stable update, Phototonic has been very, very slow on my system.
From as far as I can tell from Conky; it's not using more RAM or Swap than the previous version, but it takes a full second or more for it to switch to another image now, if it responds to input at all, where this was almost immediate in the previous version.
I haven't the foggiest why, but it makes it impossible for me to use phototonic for the purposes of quick image-browsing and -sorting.

[cryham]

I tested a recent version of Phototonic (also built from sources) on Debian 10 and have the same issue.
It is also for me a major bug and makes the (otherwise great) program unusable (after a while).

• Just clicking on an image takes nearly a second to move cursor. Also by keys moving is very slow. There should be no problem to move around with speed of key repeat e.g. 30 per second.
• Moving images takes forever. I select some (e.g. 93) images then drag and drop them to a folder, it shows the move dialog and gets stuck waiting. This is definitely some logic bug, because the files are moved and appear in new folder instantly (I see them), but the dialog still shows and waits. For me it took 26 sec for that dialog to disappear, just for 93 files. In this wasted time you can't do anything, other than killing process. The more files I move, the longer it gets.

IDK the code but my guess is that there is some logic updating view, and it gets some deadlock or something odd. Or perhaps removing (e.g. thumbinal images) takes so long? If Phototonic code didn't change than maybe Qt change broke this?

[oferkv]

Hi, strange, I will try to investigate when possible (haven't been giving any love to the project in a while...)

[sandsmark]

I did some performance improvements, so could you test with git master and see if it has improved?

[cryham]

Hi, just tested from master. Now it works way faster. Thanks.
I can use arrow keys normally in browser.

Looking closely, it still does behave a bit odd, jerky, but I guess that'd be okay for most people.
Here is more or less what happens if hold e.g. right arrow: I see a few cursor moves fast (properly) then nothing for like 300 ms or so while image number increases and then I see cursor like 10 images after last time I saw it, then a rather short freeze happens (doing nothing) and this cycle repeats like 2 times a second.

[sandsmark]

Hmm, that was one of the things I was trying to fix, or sounds related to my fix at least.

The fix was to instead of queuing up infinitely many updates when selection changes just start a timer (if not already running) that tells everything the selection has changed within 10ms. This avoids queuing up a bunch of outdated events for updating the rest of the UI, but sounds like some of the logic is broken. I'll take a look later.

edit: oh, one thing: is the tag view and/or image info view visible? One thing I also changed was to only update those if they were visible, because they were a bit slow.

[sandsmark]

Can't reproduce it here, unfortunately (tested in a fairly large folder, takes about ~5 seconds to move through everything, and I have a key repeat rate of 220).

Can you post the [General] section from ~/.config/phototonic/phototonic.conf? (The only potentially sensitive from that might be lastDir, feel free to remove that.)