Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Washing machine state isn't universal #33

Open
terminet85 opened this issue Oct 26, 2021 · 3 comments
Open

Washing machine state isn't universal #33

terminet85 opened this issue Oct 26, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@terminet85
Copy link
Contributor

I noticed that MachineState isn't applicable for each Machine. I got an state 6 that is a self-test in Tumble Dryer. Will be better create a class and extend it for each machine I guess.

{
        "statusTD":
{"StatoWiFi":"1",
                "StatoTD":"6",
                "CodiceErrore":"0",
                "Pr":"1",
                "PrPh":"2",
                "RemTime":"150",
                "DryLev":"2",
                "Time":"0",
                "Rapido":"0",
                "Opt1":"1",
                "Opt2":"1",
                "Opt3":"0",
                "Opt4":"0",
                "Opt5":"0",
                "Opt6":"0",
                "Opt7":"0",
                "Opt8":"0",
                "Refresh":"0",
                "CleanFilter":"0",
                "WaterTankFull":"0",
                "DryingManagerLevel":"2",
                "DelVal":"0",
                "DoorState":"1",
                "RecipeId":"NULL",
                "CheckUpState":"1"
        }
}
class MachineState(Enum):
    IDLE = 1
    RUNNING = 2
    PAUSED = 3
    DELAYED_START_SELECTION = 4
    DELAYED_START_PROGRAMMED = 5
    ERROR = 6
    FINISHED1 = 7
    FINISHED2 = 8

@ofalvai
Copy link
Owner

ofalvai commented Oct 29, 2021

Yes, MachineState was initially the washing machine state only, but as we added more appliance types some of them reused MachineState. Some appliances have their own state enum in model.py (ovens for example), so if tumble dryers need their own state enum, I'm more than happy to fix this if you send me the list of values and their meaning.

@TheBisk
Copy link

TheBisk commented Nov 8, 2021

hello,
for the washing machine it would be useful to have a binary sensor that indicates the status of the door, open or closed.
it's possible?
Thank you.

@ofalvai
Copy link
Owner

ofalvai commented Nov 8, 2021

@TheBisk does your washing machine expose this information in the API? My washing machine doesn't have this information in the response, but based on contributions from others, dishwashers and tumble dryers expose this.

@ofalvai ofalvai added the help wanted Extra attention is needed label Nov 22, 2021
@ofalvai ofalvai changed the title MachineState isn't universal Washing machine state isn't universal Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants