Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] developer/*: update js code to ES6 #11483

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Nov 28, 2024

This PR updates javascript code to be up to date with the codebase standards:

  • use the static keyword when possible
  • proper owl imports
  • removed unecessary @odoo-module directives

Task ID: 2258359

Forward-Port-Of: #11466

This commit updates javascript code to be up to date with the codebase
standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives

X-original-commit: 8ef0514
@robodoo
Copy link
Collaborator

robodoo commented Nov 28, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Nov 28, 2024

@BastienFafchamps this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 2, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@kebeclibre
Copy link
Contributor

@robodoo r+

@robodoo
Copy link
Collaborator

robodoo commented Dec 2, 2024

@kebeclibre you can't review+.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 3, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

5 similar comments
@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 4, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 5, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 6, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 7, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 8, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@kebeclibre
Copy link
Contributor

@AntoineVDV Hello, Can we get an r+ on that one (and/or giving me the r+ rights ?)
cheers

@fw-bot
Copy link
Collaborator Author

fw-bot commented Dec 10, 2024

@BastienFafchamps this forward port of #11466 is awaiting action (not merged or closed).

@AntoineVDV
Copy link
Collaborator

AntoineVDV commented Dec 11, 2024

@robodoo r+

I can't give r+ rights, only delegate; it's something to ask to the runbot team :p

Note that @BastienFafchamps is able to r+ since it's a forward-port of a PR he's the author of, same as on the other runbot-powered odoo/* repositories.

robodoo pushed a commit that referenced this pull request Dec 11, 2024
This PR updates javascript code to be up to date with the codebase standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives

Task ID: 2258359

closes #11483

Forward-port-of: #11466
Signed-off-by: Bastien Fafchamps (bafa) <[email protected]>
Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
robodoo pushed a commit that referenced this pull request Dec 11, 2024
This PR updates javascript code to be up to date with the codebase standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives

Task ID: 2258359

closes #11483

Forward-port-of: #11466
Signed-off-by: Bastien Fafchamps (bafa) <[email protected]>
Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
@robodoo robodoo added the 18.1 label Dec 11, 2024
@robodoo robodoo closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants