Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] developer/*: update js code to ES6 #11466

Closed
wants to merge 1 commit into from

Conversation

BastienFafchamps
Copy link
Contributor

This PR updates javascript code to be up to date with the codebase standards:

  • use the static keyword when possible
  • proper owl imports
  • removed unecessary @odoo-module directives

Task ID: 2258359

@robodoo
Copy link
Collaborator

robodoo commented Nov 27, 2024

Pull request status dashboard

@BastienFafchamps BastienFafchamps marked this pull request as ready for review November 27, 2024 13:47
@C3POdoo C3POdoo requested review from a team November 27, 2024 13:49
@ged-odoo
Copy link
Contributor

nice

Copy link
Collaborator

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate+

This commit updates javascript code to be up to date with the codebase
standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives
@BastienFafchamps
Copy link
Contributor Author

@robodoo r+

@AntoineVDV AntoineVDV changed the title [IMP] web: Update js code to ES6 [IMP] developer/*: update js code to ES6 Nov 28, 2024
@AntoineVDV
Copy link
Collaborator

@robodoo squash

@robodoo
Copy link
Collaborator

robodoo commented Nov 28, 2024

Merge method set to squash.

@robodoo robodoo closed this in 8ef0514 Nov 28, 2024
robodoo pushed a commit that referenced this pull request Dec 11, 2024
This PR updates javascript code to be up to date with the codebase standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives

Task ID: 2258359

closes #11483

Forward-port-of: #11466
Signed-off-by: Bastien Fafchamps (bafa) <[email protected]>
Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
robodoo pushed a commit that referenced this pull request Dec 11, 2024
This PR updates javascript code to be up to date with the codebase standards:
- use the `static` keyword when possible
- proper owl imports
- removed unecessary `@odoo-module` directives

Task ID: 2258359

closes #11483

Forward-port-of: #11466
Signed-off-by: Bastien Fafchamps (bafa) <[email protected]>
Signed-off-by: Antoine Vandevenne (anv) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants