Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Fiscal localizations: Add info about Teledec and liasse fiscale #11454

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

afma-odoo
Copy link
Contributor

task-4342454

@robodoo
Copy link
Collaborator

robodoo commented Nov 26, 2024

Pull request status dashboard

@afma-odoo afma-odoo requested a review from a team November 26, 2024 14:13
@C3POdoo C3POdoo requested a review from a team November 26, 2024 14:34
Copy link
Contributor

@auva-odoo auva-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this @afma-odoo 👏 really well done! In addition to my review comments/suggestions:

  • I suggest using italics for all of the French terms (including liasse fiscale), unless they are formatted using guilabel or unless it's a proper noun (like Direction Générale des Finances Publiques for example)
  • Since there's only one h3 title (Teledec), I suggest we remove it and bump up the h4s to h3 titles

Thank you!!

@afma-odoo afma-odoo force-pushed the 18.0-localization-fr-teledec-afma branch from 267a5e7 to 3745864 Compare November 28, 2024 11:47
@afma-odoo afma-odoo force-pushed the 18.0-localization-fr-teledec-afma branch from 3745864 to 3d59a6b Compare November 28, 2024 11:50
@afma-odoo
Copy link
Contributor Author

@auva-odoo Thanks for the review 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants