-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Fiscal localizations: Add info about Teledec and liasse fiscale #11454
Open
afma-odoo
wants to merge
1
commit into
18.0
Choose a base branch
from
18.0-localization-fr-teledec-afma
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auva-odoo
reviewed
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this @afma-odoo 👏 really well done! In addition to my review comments/suggestions:
- I suggest using italics for all of the French terms (including liasse fiscale), unless they are formatted using guilabel or unless it's a proper noun (like Direction Générale des Finances Publiques for example)
- Since there's only one h3 title (Teledec), I suggest we remove it and bump up the h4s to h3 titles
Thank you!!
afma-odoo
force-pushed
the
18.0-localization-fr-teledec-afma
branch
from
November 28, 2024 11:47
267a5e7
to
3745864
Compare
afma-odoo
force-pushed
the
18.0-localization-fr-teledec-afma
branch
from
November 28, 2024 11:50
3745864
to
3d59a6b
Compare
@auva-odoo Thanks for the review 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-4342454