Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data pre-scaling in tomography #751

Closed
kohr-h opened this issue Dec 1, 2016 · 3 comments
Closed

Data pre-scaling in tomography #751

kohr-h opened this issue Dec 1, 2016 · 3 comments

Comments

@kohr-h
Copy link
Member

kohr-h commented Dec 1, 2016

We should think about a flag in the ray transform operators that would skip the output scaling in each call to the backprojector. These factors are the same in each call anyway and they could be applied once to the data instead.

A helper function would make sense IMO since it can become quite involved. For example, the angle weights can actually vary if the angle distribution is not equidistant, or the magnification factors (determined by source and detector distances) could vary from projection to projection. We don't have a (simple) geometry for the latter case yet, but non-equidistant angles are definitely a thing and could be handled better than currently.

@adler-j
Copy link
Member

adler-j commented Dec 2, 2016

I agree that this should be done since it is so simple (basically factor out the function and add a flag, should take like 5 minutes). But i think the "big" gains are from issue #152, so we can skip the data reordering etc.

@adler-j
Copy link
Member

adler-j commented Jan 17, 2017

Lots of profiling done during #802, and this is not a big issue (i.m.o.), is it something you want to do regardless? perhaps it is big in some special case?

@kohr-h
Copy link
Member Author

kohr-h commented Jan 17, 2017

Lots of profiling done during #802, and this is not a big issue (i.m.o.), is it something you want to do regardless? perhaps it is big in some special case?

It could be relevant when trying to go real-time in single slices, but I haven't profiled anything. If it pops up, we can reopen. No time to do this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants