Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_midp parameter per axis #174

Closed
kohr-h opened this issue Dec 17, 2015 · 1 comment
Closed

as_midp parameter per axis #174

kohr-h opened this issue Dec 17, 2015 · 1 comment

Comments

@kohr-h
Copy link
Member

kohr-h commented Dec 17, 2015

There is an overlooked issue with grids and the handling of as_midp when combining two grids, which is common in tomography when there is a separate grid for the angles and one for the detector. We have this situation:

>>> grid = odl.RegularGrid(0, 1, 10, as_midp=False)
>>> other_grid = odl.RegularGrid(-1, 1, 20, as_midp=True)
>>> grid.insert(other_grid, 0)
>>> grid.as_midp
False

The problem is that as_midp is global, and currently the inserted grid's as_midp is silently ignored. We should make as_midp a property per axis and then set it properly when inserting. This fits well into #159, the original issue where this first came up was #172.

@kohr-h
Copy link
Member Author

kohr-h commented Feb 10, 2016

This is now handled gracefully in partitions. Closing.

@kohr-h kohr-h closed this as completed Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant