Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscreteXrayTransform does not use weighting properly #151

Closed
kohr-h opened this issue Dec 11, 2015 · 3 comments
Closed

DiscreteXrayTransform does not use weighting properly #151

kohr-h opened this issue Dec 11, 2015 · 3 comments

Comments

@kohr-h
Copy link
Member

kohr-h commented Dec 11, 2015

The current implementation of the DiscreteXrayTransform operator initializes a DiscreteLp for its range from the given geometry, however without using proper weighing. This should be fixed.

@kohr-h
Copy link
Member Author

kohr-h commented Dec 13, 2015

I should add that this refers to a branch. The exact location of the bug is here. The space initializer should use geometry.grid.cell_volume() as weight.

This is only a temporary fix, we need to have a closer look on the desired structure of the range.

@adler-j
Copy link
Member

adler-j commented Feb 9, 2016

This should be fixed now, correct?

@kohr-h
Copy link
Member Author

kohr-h commented Feb 9, 2016

It is indeed, but still on a branch, so technically it's still open. But since there is no bug on master, let's say it's fixed. We should, however, open a new one regarding non-uniform sampling of the angles and the weights which follow from that. It's not supported yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants