Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible axis ordering in geometries #1071

Open
kohr-h opened this issue Jul 10, 2017 · 2 comments
Open

More flexible axis ordering in geometries #1071

kohr-h opened this issue Jul 10, 2017 · 2 comments

Comments

@kohr-h
Copy link
Member

kohr-h commented Jul 10, 2017

Our choice of axis ordering is reasonable when one wants to deal with projection images one at a time, but for other purposes it may be more reasonable to have a different ordering (for example to match the ordering of the backend, thereby removing overhead in copying and transposing data).

My suggestion for geometries in general is that we remove the lumped together attributes partition, params and grid, thus making geometries agnostic of axis ordering. The "consumers" of geometries (i.e. mostly RayTransform) should be responsible for handling axes in the data.

I think this change would only affect internal stuff and not break any user code.

@kohr-h
Copy link
Member Author

kohr-h commented Jul 10, 2017

Related to #152

@adler-j
Copy link
Member

adler-j commented Jul 10, 2017

Frankly I agree. The current ordering is somewhat arbitrary to enforce on a global scale. It also causes issues for geometries that don't really have any motion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants