Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue when UITabBarItem's title is positioned next to image #1

Closed
rdoubleui opened this issue Aug 10, 2018 · 1 comment
Closed

Issue when UITabBarItem's title is positioned next to image #1

rdoubleui opened this issue Aug 10, 2018 · 1 comment

Comments

@rdoubleui
Copy link
Contributor

In general I was wondering if you still maintain this repository? I tried your approach and found that it only works for tab bar items that got their caption underneath as you're relying on the middle of the tab bar item to position the indicator/badge.

I'd suggest an approach where the indicator/badge would be positioned based on the actual position of the image within the tab bar item. Would be interested in accepting pull requests to fix this issue?
@odedharth
Copy link
Owner

@rdoubleui feel free to send a pull request 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdoubleui @odedharth