From 48b7856a03f94c0dd10bbe1a9c7abf1709509c57 Mon Sep 17 00:00:00 2001
From: Florian Scholz <fs@florianscholz.com>
Date: Mon, 28 Oct 2024 16:36:56 +0100
Subject: [PATCH] Add more keys to PiP and use compute_from (#2050)

---
 features/picture-in-picture.yml      | 19 ++++++----------
 features/picture-in-picture.yml.dist | 33 ++++++++++++++++++++++++++++
 2 files changed, 40 insertions(+), 12 deletions(-)

diff --git a/features/picture-in-picture.yml b/features/picture-in-picture.yml
index 49f0045c9877..3b16fa3e3011 100644
--- a/features/picture-in-picture.yml
+++ b/features/picture-in-picture.yml
@@ -2,12 +2,8 @@ name: Picture-in-picture (video)
 description: The picture-in-picture API allow websites to create a floating, always-on-top video window. Also known as PiP or pop-out video.
 spec: https://w3c.github.io/picture-in-picture/
 caniuse: picture-in-picture
-# TODO: Align the initial Chrome version these sources:
-# https://github.com/mdn/browser-compat-data/pull/7603 (Chrome 69)
-# https://caniuse.com/picture-in-picture (Chrome 70)
-# https://chromestatus.com/feature/5729206566649856 (Chrome 71)
-#
-# For now we will match BCD, Chrome 69.
+status:
+  compute_from: api.Document.pictureInPictureElement
 compat_features:
   - api.Document.exitPictureInPicture
   - api.Document.pictureInPictureElement
@@ -22,9 +18,8 @@ compat_features:
   - api.PictureInPictureWindow.width
   - api.ShadowRoot.pictureInPictureElement
   - html.elements.video.disablepictureinpicture
-  # Later additions:
-  # - api.PictureInPictureEvent
-  # - api.PictureInPictureEvent.PictureInPictureEvent
-  # - api.PictureInPictureEvent.pictureInPictureWindow
-  # - css.selectors.picture-in-picture
-  # - http.headers.Permissions-Policy.picture-in-picture
+  - api.PictureInPictureEvent
+  - api.PictureInPictureEvent.PictureInPictureEvent
+  - api.PictureInPictureEvent.pictureInPictureWindow
+  - css.selectors.picture-in-picture
+  - http.headers.Permissions-Policy.picture-in-picture
diff --git a/features/picture-in-picture.yml.dist b/features/picture-in-picture.yml.dist
index 7ecb384c1546..27fc16a7a34f 100644
--- a/features/picture-in-picture.yml.dist
+++ b/features/picture-in-picture.yml.dist
@@ -10,6 +10,14 @@ status:
     safari: "13.1"
     safari_ios: "13.4"
 compat_features:
+  # ⬇️ Same status as overall feature ⬇️
+  # baseline: false
+  # support:
+  #   chrome: "69"
+  #   chrome_android: "105"
+  #   edge: "79"
+  #   safari: "13.1"
+  #   safari_ios: "13.4"
   - api.Document.exitPictureInPicture
   - api.Document.pictureInPictureElement
   - api.Document.pictureInPictureEnabled
@@ -23,3 +31,28 @@ compat_features:
   - api.PictureInPictureWindow.width
   - api.ShadowRoot.pictureInPictureElement
   - html.elements.video.disablepictureinpicture
+
+  # baseline: false
+  # support:
+  #   chrome: "85"
+  #   chrome_android: "105"
+  #   edge: "85"
+  #   safari: "16"
+  #   safari_ios: "16"
+  - api.PictureInPictureEvent
+  - api.PictureInPictureEvent.PictureInPictureEvent
+  - api.PictureInPictureEvent.pictureInPictureWindow
+
+  # baseline: false
+  # support:
+  #   chrome: "110"
+  #   chrome_android: "110"
+  #   edge: "110"
+  #   safari: "13.1"
+  #   safari_ios: "13.4"
+  - css.selectors.picture-in-picture
+
+  # baseline: false
+  # support:
+  #   chrome: "88"
+  - http.headers.Permissions-Policy.picture-in-picture