-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-detect sass
vs sass-embedded
#290
Comments
The pipelines on our project did not fail for the change to replace |
Sorry for creating an issue in a rush. It turns out that this problem can be avoided by simply passing the import { dirname, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import * as sass from "sass-embedded";
import sassTrue from "sass-true";
import { describe, it } from "vitest";
describe("Sass", () => {
const sassTestFiles = Object.keys(
import.meta.glob("./**/*.test.scss", { eager: true }),
).map((relativePath) => {
return resolve(dirname(fileURLToPath(import.meta.url)), relativePath);
});
sassTestFiles.forEach((file) =>
sassTrue.runSass({ describe, it, sass }, file),
);
}); I think it would still be beneficial if |
@JoostKersjes I think that's a good idea -- I've renamed this issue. |
I'm using
"sass-true": "8.0.0"
and incorrectly assumed that it would work with"sass-embedded": "1.79.2"
.The reason for replacing
sass
withsass-embedded
is mostly for improved performance.Error message:
The text was updated successfully, but these errors were encountered: