Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcuts and other fixes, start changelog #8

Merged
merged 7 commits into from
Dec 26, 2023
Merged

Conversation

mirisuzanne
Copy link
Member

  • 💥 BREAKING: Updated keyboard shortcuts
    to match PowerPoint,
    including command-. as 'end presentation'
    rather than 'toggle full-screen' (now command-shift-f)
  • 🚀 NEW: Support for blank-screen shortcuts
    (inspired by Curtis Wilcox)
  • 🚀 NEW: Control panel includes toggle for keyboard controls
  • 🚀 NEW: Control panel buttons have aria-pressed styles
  • 🚀 NEW: All slide-event buttons that toggle a boolean state
    get aria-pressed values that update with the state
  • 🐞 FIXED: Scroll to the active slide when changing views
  • 🐞 FIXED: Control panel view toggles were broken
  • 🐞 FIXED: Control panel prevents propagation of keyboard shortcuts
  • 👀 INTERNAL: The current slide is stored in an activeSlide property

Related Issue(s)

Reminder to add related issue(s), if available.

Steps to test/reproduce

Please explain how to best reproduce the issue and/or test the changes locally (including the pages/URLs/views/states to review).

  • try the various shortcuts
  • try the buttons in the control panel

Copy link

netlify bot commented Dec 26, 2023

Deploy Preview for slide-deck ready!

Name Link
🔨 Latest commit e21e131
🔍 Latest deploy log https://app.netlify.com/sites/slide-deck/deploys/658b2514aaf062000820bec7
😎 Deploy Preview https://deploy-preview-8--slide-deck.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mirisuzanne mirisuzanne merged commit f9830c7 into main Dec 26, 2023
4 checks passed
@mirisuzanne mirisuzanne deleted the shortcuts branch December 26, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure that keyboard shortcuts match common apps/remotes
1 participant