Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen handler not setup properly for Firefox #1

Open
mirisuzanne opened this issue Dec 22, 2023 · 1 comment
Open

Fullscreen handler not setup properly for Firefox #1

mirisuzanne opened this issue Dec 22, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mirisuzanne
Copy link
Member

mirisuzanne commented Dec 22, 2023

Describe the bug

Firefox is refusing to put slides into fullscreen mode:

Request for fullscreen was denied because Element.requestFullscreen() was not called from inside a short running user-generated event handler.

To Reproduce

  1. Open in Firefox
  2. Use the shortcut to enter fullscreen mode (depends on branch)
  3. Check console for error

Expected behaviour

Enter fullscreen mode.

Additional context

Fullscreen works in Chromium & Webkit browsers.

@mirisuzanne mirisuzanne added bug Something isn't working help wanted Extra attention is needed labels Dec 22, 2023
@mirisuzanne mirisuzanne added this to the v1.0 Production-Ready milestone Dec 22, 2023
@mirisuzanne
Copy link
Member Author

I thought 70a0411 might fix this, but it did not. Do we need a 'shorter lived' listener specifically for the fullscreen request? This is supposed to happen 'within 1s' - and it clearly is, so there must be some other issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant