Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill doesn't seem to work with dialog element #198

Closed
samGbos opened this issue Apr 24, 2024 · 3 comments · Fixed by #199
Closed

Polyfill doesn't seem to work with dialog element #198

samGbos opened this issue Apr 24, 2024 · 3 comments · Fixed by #199

Comments

@samGbos
Copy link

samGbos commented Apr 24, 2024

I was trying to set a <dialog> to be a popover as discussed here: https://hidde.blog/popover-semantics/

However, this doesn't seem to work in Firefox; the popover does seem to work with a <div> element though:
https://codepen.io/codepenguy131/pen/jORdKGo

@jgerigmeyer
Copy link
Member

@samGbos Thanks for reporting! It looks to me like that's a bug -- I've submitted a fix in #199: https://deploy-preview-199--popover-polyfill.netlify.app/

@samGbos
Copy link
Author

samGbos commented Apr 24, 2024

Amazing, thanks! Such a quick response!

@jgerigmeyer
Copy link
Member

@samGbos Released in v0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants