New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Click to toggle shadowed Popover" crashes in Firefox 118 #139

Closed

jgerigmeyer opened this issue Oct 19, 2023 · 0 comments · Fixed by #160

Member

jgerigmeyer commented Oct 19, 2023

It's not new in this PR, but I notice that the "Click to toggle shadowed Popover" button crashes the tab for me when clicked in FF 118

That's interesting. Is that on stock Firefox, or have you enabled popovers or some shadowdom features? I can't reproduce locally, but it'd be interesting to investigate. Do you have a crash report?

This is stock Firefox 118.0.2 with popovers disabled. It works fine for me in Safari 16.6 (using the polyfill). If I test in Chrome (popovers enabled) or Firefox (popovers enabled), the button just doesn't do anything. Crash report: https://crash-stats.mozilla.org/report/index/7ac206de-9229-402a-9e6f-31ee80231019

Originally posted by @jgerigmeyer in #137 (comment)

keithamus mentioned this issue

prevent default on clicks to avoid firefox crash #160

Merged

jgerigmeyer closed this as completed in #160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment