Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint for x-maintenance-intent #415

Open
shonfeder opened this issue Jan 16, 2025 · 4 comments
Open

Add lint for x-maintenance-intent #415

shonfeder opened this issue Jan 16, 2025 · 4 comments
Assignees

Comments

@shonfeder
Copy link
Contributor

It should validate that the format is correct when present. We'd also like a warning (not a failure) when it is absent. See https://github.com/ocaml/opam-repository/blob/master/governance/policies/archiving.md#specification-of-the-x--fields-used-in-the-archiving-process for the format.

See also @raphael-proust's https://github.com/raphael-proust/maintenance-intent-filter . We should share that code if possible.

@hannesm
Copy link
Contributor

hannesm commented Feb 28, 2025

I would appreciate this becoming reality :)

@shonfeder
Copy link
Contributor Author

shonfeder commented Mar 3, 2025

@hannesm where is currently the canonical source of truth for the valid format? Is there already re-usable code to validate it we can plug in here?

@shonfeder shonfeder self-assigned this Mar 3, 2025
@hannesm
Copy link
Contributor

hannesm commented Mar 3, 2025

@shonfeder sorry, I don't have a "canonical source of truth for the valid format". https://github.com/hannesm/maintenance-intent-filter/blob/develop/mintent.ml is what I use, based on @raphael-proust code https://github.com/raphael-proust/maintenance-intent-filter , the extension is to support "(none)" as well.

@shonfeder
Copy link
Contributor Author

shonfeder commented Mar 6, 2025

We discussed in the opam maintainers meeting today, and the aim is to publish https://github.com/raphael-proust/maintenance-intent-filter, with a check function, which we can then plug in to the linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants