[BUG]: DateTimeOffsetConverter uses 32-bit integer instead of 64-bit

[martincostello]

What happened?

When converting numbers to DateTimeOffset instances, a 32-bit integer (int) is used:

webhooks.net/src/Octokit.Webhooks/Converter/DateTimeOffsetConverter.cs

Line 28 in 6f68314

private static DateTimeOffset HandleNumber(Utf8JsonReader reader) => DateTimeOffset.FromUnixTimeSeconds(reader.GetInt32());

The DateTimeOffset.FromUnixTimeSeconds() method accepts a long rather than an int, which means two things:

1. There's a hidden implicit conversion paid to convert the value anyway.
2. The code will stop working for timestamps representing times greater than 19/01/2038 03:14:07 +00:00.

I just happened to notice this while reviewing something in the code.

Versions

All

Relevant log output

N/A

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀