Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Pagination: do not add ?{page,per_page} parameters for list endpoints only supporting ?since` #700

Open
gr2m opened this issue Apr 22, 2020 · 0 comments
Labels
feature New feature or request

Comments

@gr2m
Copy link
Contributor

gr2m commented Apr 22, 2020

Follow up to https://github.com/octokit/rest.js/issues/1684#issuecomment-617998848

Example, but there are many

We can look for this note:

Note: Pagination is powered exclusively by the since parameter. Use the Link header to get the URL for the next page of repositories.

Current specification

{
"name": "per_page",
"description": "Results per page (max 100)",
"in": "query",
"schema": { "type": "integer", "default": 30 }
},
{
"name": "page",
"description": "Page number of the results to fetch.",
"in": "query",
"schema": { "type": "integer", "default": 1 }
}

I expected

per_page and page parameters should not be present

@gr2m gr2m self-assigned this Apr 22, 2020
@gr2m gr2m added the feature New feature or request label May 5, 2020
@gr2m gr2m removed their assignment May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant