Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Invalid enum values for list workflow runs #664

Open
miyajan opened this issue Feb 24, 2020 · 7 comments
Open

Invalid enum values for list workflow runs #664

miyajan opened this issue Feb 24, 2020 · 7 comments
Labels
bug Something isn't working as documented, or is being fixed

Comments

@miyajan
Copy link

miyajan commented Feb 24, 2020

Current specification

{
"name": "status",
"description": "Returns workflow runs associated with the check run `status` or `conclusion` you specify. For example, a conclusion can be `success` or a status can be `completed`. For more information, see the `status` and `conclusion` options available in \"[Create a check run](https://developer.github.com/v3/checks/runs/#create-a-check-run).\"",
"in": "query",
"required": false,
"schema": {
"type": "string",
"enum": ["completed", "status", "conclusion"]
}
},

I expected

"status" param can be one of the check run "status" or "conclusion"
    {
      "name": "status",
      "description": "Returns workflow runs associated with the check run `status` or `conclusion` you specify. For example, a conclusion can be `success` or a status can be `completed`. For more information, see the `status` and `conclusion` options available in \"[Create a check run](https://developer.github.com/v3/checks/runs/#create-a-check-run).\"",
      "in": "query",
      "required": false,
      "schema": {
        "type": "string",
        "enum": [
          "queued",
          "in_progress",
          "completed",
          "success",
          "failure",
          "neutral",
          "cancelled",
          "timed_out",
          "action_required"
        ]
      }
    },
@gr2m gr2m added the bug Something isn't working as documented, or is being fixed label Feb 24, 2020
@gr2m
Copy link
Contributor

gr2m commented Feb 24, 2020

Did you by chance test if the status supports enum values from both check run status & conclusion?

@miyajan
Copy link
Author

miyajan commented Feb 24, 2020

Yes, I tested. When I specified "completed", list workflow runs returned both successful and failed runs. And when I specified "success", it returned only successful runs. It seems the status parameter supports enum values from both check run status & conclusion.

@gr2m
Copy link
Contributor

gr2m commented Feb 24, 2020

Thanks Miyata, I've shortly talked to the docs team. They are on a week-long summit right now so it might take a moment to be addressed, but I'm sure it will be resolved soon. I'll keep you posted

@miyajan
Copy link
Author

miyajan commented Feb 25, 2020

Thank you for your quick response😆

@miyajan
Copy link
Author

miyajan commented Mar 17, 2020

@gr2m Any update on this issue?

@gr2m
Copy link
Contributor

gr2m commented Mar 17, 2020

Sorry I dropped the ball on this one. Is this a blocker for you in some way?

@miyajan
Copy link
Author

miyajan commented Mar 17, 2020

This is not blocker for me because I execute the API with a way other than octokit now. But I don't like this workaround, so please fix it.🙇‍♂️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working as documented, or is being fixed
Projects
None yet
Development

No branches or pull requests

2 participants