Skip to content
This repository has been archived by the owner on Jul 27, 2020. It is now read-only.

Add required app permissions to routes #523

Open
gr2m opened this issue Sep 9, 2019 · 2 comments
Open

Add required app permissions to routes #523

gr2m opened this issue Sep 9, 2019 · 2 comments
Labels
feature New feature or request

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 9, 2019

We can scrape this page:
https://developer.github.com/v3/apps/permissions/ and it's GitHub Enterprise (Server) counterparts

@MaximDevoir
Copy link

MaximDevoir commented Dec 31, 2019

I think this could also be utilized by Probot. The larger goal with helper features like webhook-event-check is to help developers catch permissions-related issues with their GitHub App faster.

With permissions information for each route, Probot could be able to compare the permissions received from GET /app to the ones required with each request. I've got a few other alternative solutions I'll explore when it gets to that.

I'll explore this codebase and try to understand how everything works and then work on a PR for this issue. My goal will be to get a PR posted by the end of January February.

@gr2m
Copy link
Contributor Author

gr2m commented Jan 2, 2020

Holler if you have any questions

@gr2m gr2m added the feature New feature or request label May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants