[BUG]: Typechecking fails for external code with exactOptionalPropertyTypes: true

[ammubhave]

What happened?

When typescript is used with the option exactOptionalPropertyTypes: true, most code that consumes this library fails to typecheck if undefined is passed in for the response value.

All optional properties must have explicit | undefined in their type definitions.

Versions

all

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[wolfy1339]

Are you explicitly passing undefined or defining the value at all?

It would be nice to enable this option ourselves across all Octokit repos.

[oscard0m]

Are you explicitly passing undefined or defining the value at all?

It would be nice to enable this option ourselves across all Octokit repos.

I would be happy to give it a try to this. After trying to read a bit about this I got this blog post where it gives good points to enabling this option in out TS Config.

@wolfy1339 would it be ok if I give it a try? If yes, I will create an issue in https://github.com/octokit/tsconfig and we can discuss the plan there.

[wolfy1339]

Sure, go ahead

[github-actions]

🎉 This issue has been resolved in version 6.1.5 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀