[BUG]: Cannot construct a Request with a Request object that has already been used.

[jakub-g]

What happened?

Today GitHub had an outage (related: #2) and the API was replying with 500s.

Due to this, the retry plugin has been retrying failed requests in our CI, but those retries were failing with Cannot construct a Request with a Request object that has already been used..

Versions

octokit-request 8.1.4
octokit-plugin-retry 6.0.1
node 20.10.0

Relevant log output

<path-to-repo>/.yarn/__virtual__/@octokit-plugin-retry-virtual-913e8d7a91/0/cache/@octokit-plugin-retry-npm-6.0.1-b38996e6ff-2f5cd8b221.zip/node_modules/@octokit/plugin-retry/dist-node/index.js:71
  const response = await request(request, options);
                   ^
RequestError [HttpError]: Cannot construct a Request with a Request object that has already been used.
    at <path-to-repo>/.yarn/cache/@octokit-request-npm-8.1.4-e871d5ebf1-a51470f470.zip/node_modules/@octokit/request/dist-node/index.js:144:11
    at async requestWithGraphqlErrorHandling (<path-to-repo>/.yarn/__virtual__/@octokit-plugin-retry-virtual-913e8d7a91/0/cache/@octokit-plugin-retry-npm-6.0.1-b38996e6ff-2f5cd8b221.zip/node_modules/@octokit/plugin-retry/dist-node/index.js:71:20)
    at async Job.doExecute (<path-to-repo>/.yarn/cache/bottleneck-npm-2.19.5-2c6092aa17-084e33d97e.zip/node_modules/bottleneck/light.js:405:18) {
  status: 500,
  request: {
    method: 'PATCH',
    url: 'https://api.github.com/repos/<org>/<repo>/issues/comments/<id>',
    headers: {
      accept: 'application/vnd.github.v3+json',
      'user-agent': 'octokit.js/3.1.2 octokit-core.js/5.0.1 Node.js/20.10.0 (linux; arm64)',
      authorization: 'token [REDACTED]',
      'content-type': 'application/json; charset=utf-8'
    },

The underlying error comes from undici (which is nodejs built-in fetch impl) which is used by octokit/request:

• https://github.com/nodejs/undici/blob/ad811224c63c99d6840475f9805ea6dbe8be7747/lib/web/fetch/request.js#L542

Code of Conduct

• I agree to follow this project's Code of Conduct

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[gr2m]

Could you share a minimal reproducible test case please? I've haven't seen this error before, and I have plenty of request retries across my projects, many of which use latest octokit with the native fetch from unidici

[jakub-g]

@gr2m Thanks for replying - we just realized this is coming from a regression in the dd-trace library. Closing.