Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @octokit/core as peerDependency #77

Closed
gr2m opened this issue Aug 26, 2020 · 2 comments · Fixed by #124
Closed

Add @octokit/core as peerDependency #77

gr2m opened this issue Aug 26, 2020 · 2 comments · Fixed by #124
Assignees
@HeroicHitesh

Comments

@gr2m
Copy link
Contributor

gr2m commented Aug 26, 2020

This is a follow up issue to octokit/plugin-paginate-rest.js#124 (comment)

We need to add @octokit/core as a peerDependency to address a problem with yarn 2. It is something I planned to do anyway, but wanted to figure out automated testing to assure compatibility of the plugins with the latest @octokit/core.

I only want to define compatibility with the lowest version, in this case v3. Compare pull request https://github.com/octokit/plugin-paginate-rest.js/pull/130/files.

I would appreciate help, this is a great issue for a first-time contributor
@gr2m gr2m added the bug label Sep 10, 2020
@HeroicHitesh
Copy link
Contributor

@gr2m I am working on it

@HeroicHitesh HeroicHitesh mentioned this issue Oct 22, 2020
Merged
@gr2m gr2m closed this as completed in #124 Oct 22, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HeroicHitesh HeroicHitesh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(package): add @octokit/core as peer dependency HeroicHitesh/plugin-request-log.js
2 participants
@gr2m @HeroicHitesh