Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: done parameter for the .paginate() callback should not be optional #261

Merged
merged 1 commit into from
Jan 25, 2021
Merged

fix: done parameter for the .paginate() callback should not be optional #261

merged 1 commit into from
Jan 25, 2021

Conversation

ptomulik
Copy link
Contributor

Closes #259

@oscard0m oscard0m added the bug label Jan 25, 2021
@oscard0m oscard0m added the typescript Relevant to TypeScript users only label Jan 25, 2021
@oscard0m oscard0m merged commit 65f31bf into octokit:master Jan 25, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscard0m oscard0m oscard0m approved these changes

Assignees
No one assigned
Labels
typescript Relevant to TypeScript users only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The done parameter for the .paginate() callback should not be optional
2 participants
@ptomulik @oscard0m