From c411d9153372f57787c83ffad25201556068bede Mon Sep 17 00:00:00 2001 From: Sean Killeen Date: Mon, 9 Jan 2017 10:52:40 -0500 Subject: [PATCH 1/3] Update label docs to reflect color information Resolves #790 --- docs/labels.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/labels.md b/docs/labels.md index 63cc8cb185..b3afed4a6d 100644 --- a/docs/labels.md +++ b/docs/labels.md @@ -14,3 +14,8 @@ The default labels that come with every repository are: - invalid - question - wontfix + +## A Note on Label Colors +The official API returns colors without the leading `#` that you may expect when working with hex colors -- for example, white would return `FFFFFF`, not `#FFFFFF`. + +If you're translating these directly the colors, you may need to modify them to add the `#` in order to display them properly. \ No newline at end of file From c4f6f17aef0cde33e9471c6651e070c89f495a07 Mon Sep 17 00:00:00 2001 From: Sean Killeen Date: Mon, 9 Jan 2017 11:11:48 -0500 Subject: [PATCH 2/3] Clarify doc language Because I couldn't just have a one-commit PR. No, that'd be too easy. --- docs/labels.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/labels.md b/docs/labels.md index b3afed4a6d..3277a8ae6f 100644 --- a/docs/labels.md +++ b/docs/labels.md @@ -18,4 +18,4 @@ The default labels that come with every repository are: ## A Note on Label Colors The official API returns colors without the leading `#` that you may expect when working with hex colors -- for example, white would return `FFFFFF`, not `#FFFFFF`. -If you're translating these directly the colors, you may need to modify them to add the `#` in order to display them properly. \ No newline at end of file +If you're displaying the colors, you may need to modify this field to add the `#` in order to display them properly. \ No newline at end of file From 020406c196a047cb2c6d5b8135437b6697e02c65 Mon Sep 17 00:00:00 2001 From: Sean Killeen Date: Mon, 9 Jan 2017 11:12:32 -0500 Subject: [PATCH 3/3] Futher clarification I guess we might as well make it right. --- docs/labels.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/labels.md b/docs/labels.md index 3277a8ae6f..494a7aa51b 100644 --- a/docs/labels.md +++ b/docs/labels.md @@ -18,4 +18,4 @@ The default labels that come with every repository are: ## A Note on Label Colors The official API returns colors without the leading `#` that you may expect when working with hex colors -- for example, white would return `FFFFFF`, not `#FFFFFF`. -If you're displaying the colors, you may need to modify this field to add the `#` in order to display them properly. \ No newline at end of file +If you're displaying the colors, you may need to add the `#` in order to display them properly. \ No newline at end of file