Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assignee is missing from PullRequest class #910

Closed
Eilon opened this issue Sep 23, 2015 · 6 comments
Closed

Assignee is missing from PullRequest class #910

Eilon opened this issue Sep 23, 2015 · 6 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@Eilon
Copy link
Contributor

Eilon commented Sep 23, 2015

This type: https://github.com/octokit/octokit.net/blob/master/Octokit/Models/Response/PullRequest.cs

The GitHub API response for PRs returns user (who submitted the PR) and assignee (who the PR is assigned to).

Seems like it just involves adding an Assignee property and ctor param to the PullRequest class?
@Eilon
Copy link
Contributor Author

Eilon commented Sep 23, 2015

If that's all it takes I can send a PR.

@Eilon
Copy link
Contributor Author

Eilon commented Sep 23, 2015

@haacked because reasons.

@hnrkndrssn
Copy link
Contributor

Yes, it should just be as easy as adding that property to the class and a ctor parameter. 😀

@haacked
Copy link
Contributor

haacked commented Sep 23, 2015

@Eilon do eeet!

@Eilon Eilon mentioned this issue Sep 23, 2015
Closed
@Eilon
Copy link
Contributor Author

Eilon commented Sep 23, 2015

Yessir!

@poisonous-milk poisonous-milk mentioned this issue Oct 10, 2015
Closed
@shiftkey shiftkey mentioned this issue Nov 3, 2015
Merged
@Eilon
Copy link
Contributor Author

Eilon commented Nov 3, 2015

Sweet, I didn't even have to write any code 😄

@Eilon Eilon mentioned this issue Jan 31, 2016
Closed
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@haacked @nickfloyd @Eilon @hnrkndrssn