Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue response should return CommentsUrl #883

Closed
shiftkey opened this issue Sep 8, 2015 · 5 comments
Closed

Issue response should return CommentsUrl #883

shiftkey opened this issue Sep 8, 2015 · 5 comments
Assignees
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

shiftkey commented Sep 8, 2015

https://developer.github.com/v3/issues/#list-issues

{
    "id": 1,
    "url": "https://api.github.com/repos/octocat/Hello-World/issues/1347",
    "labels_url": "https://api.github.com/repos/octocat/Hello-World/issues/1347/labels{/name}",
    "comments_url": "https://api.github.com/repos/octocat/Hello-World/issues/1347/comments",
    "events_url": "https://api.github.com/repos/octocat/Hello-World/issues/1347/events",
    "html_url": "https://github.com/octocat/Hello-World/issues/1347",
    "number": 1347,
    "state": "open",
    ...
}

See #882 for related discussion.

@naveensrinivasan
Copy link

Can I take this one?

@haacked
Copy link
Contributor

haacked commented Sep 8, 2015

@naveensrinivasan go for it!

@haacked haacked assigned haacked and unassigned haacked Sep 8, 2015
@haacked
Copy link
Contributor

haacked commented Sep 8, 2015

I assigned myself so nobody takes it. But go ahead and work on it @naveensrinivasan

@M-Zuber
Copy link
Contributor

M-Zuber commented Sep 9, 2015

This is awesome. Let's me throw out ~200 loc and tests!

@shiftkey
Copy link
Member Author

Fixed in #884

@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

5 participants