Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadlock in ASP.NET MVC #831

Closed
qin-nz opened this issue Jul 3, 2015 · 3 comments
Closed

deadlock in ASP.NET MVC #831

qin-nz opened this issue Jul 3, 2015 · 3 comments
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented

Comments

@qin-nz
Copy link

qin-nz commented Jul 3, 2015

I am using following method in a async method, and it deadlock will occured.

var masterUri = await GitHubClient.Repository.Content.GetArchiveLink(Owener, Repo, ArchiveFormat.Zipball).ConfigureAwait(false);
@qin-nz
Copy link
Author

qin-nz commented Jul 3, 2015

My code is following:

  public ActionResult DeployWebsite()
        {
            var deployId = Guid.NewGuid();
            var deploys = new WebsiteDeploy(deployId) ;
            deploy.StartFullDeploy();
            return RedirectToAction("DeployLog");
        }
  public void StartFullDeploy()
        {
            FullDeployAsync();
        }
  public async Task FullDeployAsync()
        {
            try
            {
                var masterDirectory = await DownloadMasterFromGithub().ConfigureAwait(false);
                Log("成功下载文件");
            }
            catch (Exception ex)
            {
                Log("出现异常");
            }
        }

@shiftkey
Copy link
Member

shiftkey commented Jul 3, 2015

Thanks for reporting this.

This method will change in the next release but I'll review this once #808 lands (as the 302 behaviour there affects this code).

@shiftkey shiftkey added the bug label Mar 11, 2016
@github-actions
Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Stale label Jul 26, 2022
@github-actions github-actions bot closed this as completed Aug 3, 2022
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented Status: Stale Used by stalebot to clean house and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Type: Bug Something isn't working as documented
Projects
None yet
Development

No branches or pull requests

3 participants