Uploading assets over 20Mb fails.

[distantcam]

We keep getting a failure when uploading an asset to a release when the asset is over 20Mb. We tested with multiple repos.

Is there a limit in octokit or the GitHub api? Is that limit increased or removed if we authenticate first?

[haacked]

Hmm, I believe the file size limit is 50MB. https://help.github.com/articles/working-with-large-files

I'm not aware if there's a different limit for unauthenticated users. Want to try that first? If it doesn't work, I can dig into it more.

[shiftkey]

@haacked this is for the Releases API

@distantcam I've not seen anything documented about size limits here: https://developer.github.com/v3/repos/releases/#upload-a-release-asset so i'm now looking behind the scenes for more information...

[distantcam]

@haacked Turns out I was authenticating first.

[distantcam]

Ok, so a colleague reported hitting a file limit of 20Mb. Meanwhile I was having issues with 10Mb.

I suspect this is the culprit. https://github.com/octokit/octokit.net/blob/master/Octokit/Http/Request.cs#L14

The connection is timing out before the upload is complete. Yay for Australian internet speeds.

[shiftkey]

Right, so it sounds like we need to merge #554 in

[shiftkey]

@distantcam can you sit Fiddler in between and see that it's not an exception from the backend you're seeing (i.e. that it actually times out)?

[distantcam]

@shiftkey Yep, not seeing an error from the wire, so it's definitely a timeout. Also the exception I was getting was a Task Cancellation which I'm guessing comes from the HttpClient.

[shiftkey]

🆒 so we know where the problem lies at least

[shiftkey]

Addressed indirectly in #587 which went out in v0.5.3