Pluralized API? Yea or Nay?

[shiftkey]

So we have docs that look like this

And our interface for the root GitHubClient looks like this:

IAuthorizationsClient Authorization { get; }
IActivitiesClient Activity { get; }
IIssuesClient Issue { get; }
IMiscellaneousClient Miscellaneous { get; }
IOrganizationsClient Organization { get; }
IRepositoriesClient Repository { get; }
IGistsClient Gist { get; }
IReleasesClient Release { get; }
ISshKeysClient SshKey { get; }
IUsersClient User { get; }
INotificationsClient Notification { get; }
IGitDatabaseClient GitDatabase { get; }
ISearchClient Search { get; }
IStatisticsClient Statistics { get; }

Two questions I have:

• should we normalize on what the API docs use in terms of pluralization?
• should our interfaces/implementations follow these same rules? (i.e. IActivityClient instead of IActivitiesClient)

[haacked]

I did singular for the property names because Users.Get makes me think it's getting all users vs User.Get is clear it's one. But for the type name, I like the plural to match (more or less) the API. So 👍 to IActivityClient as Activity is both singular and plural so we can't be wrong.

[anaisbetts]

We've already shipped public releases, the ⛵ has sailed on this one. Don't Break People™

[shiftkey]

We've already shipped public releases, the ⛵ has sailed on this one.

Not sure I agree with this. We're pre 1.0 still and there's a lot of work to do yet before we get there.

[haacked]

I agree with @shiftkey. We've deliberately not cut a 1.0 release for this reason. Also, Octokit on NuGet has 557 downloads. I think people will survive.

It's a disappointingly low count, but we haven't really put our marketing muscle into it yet.

[shiftkey]

We're doing an API audit in #1038 and have marked a few things as obsolete in the most recent release.

I think we settled on singular for the naming convention, but we'll use that to keep things up to date (and later enforce this via convention/integration tests)