Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completing "Search Users" API #276

Closed
3 tasks
shiftkey opened this issue Dec 24, 2013 · 2 comments
Closed
3 tasks

Completing "Search Users" API #276

shiftkey opened this issue Dec 24, 2013 · 2 comments

Comments

@shiftkey
Copy link
Member

We need to tidy up the SearchUsersRequest class:

https://github.com/octokit/octokit.net/blob/master/Octokit/Models/Request/SearchUsersRequest.cs

to match what is currently in the API documentation:

http://developer.github.com/v3/search/#search-users

  • no longer subclass RequestParameters, but expose a Parameters property and build it up similar to how SearchRepositoriesRequest works
  • re-add the Sort property
  • add some tests
@shiftkey shiftkey mentioned this issue Dec 24, 2013
Closed
@hahmed
Copy link
Contributor

hahmed commented Dec 31, 2013

I got this ⚡

@hahmed hahmed mentioned this issue Dec 31, 2013
Merged
2 tasks
@shiftkey
Copy link
Member Author

So this happened! 🤘 🎉 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiftkey @hahmed