Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify and mark or fix potentially flaky tests #2510

Closed
snyrting6github opened this issue Jul 23, 2022 · 3 comments
Closed

Identify and mark or fix potentially flaky tests #2510

snyrting6github opened this issue Jul 23, 2022 · 3 comments
Assignees
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@snyrting6github
Copy link

I've made a start on marking potentially flaky tests. These are tests which reference existing resources outside of those created by the tests themselves. While they are likely to be harmless (I can't see the octokit organisation going away soon for example), we should really be testing in pure isolation if possible.

I have created (in an upcoming PR) an attribute for doing this so we can identify them in the future more easily:
[PotentiallyFlakyTest]

These types of tests should be marked as potentially flaky or fixed.

@JonruAlveus
Copy link
Collaborator

🙄 me again...

@JonruAlveus
Copy link
Collaborator

See #2511 for attribute usage.

@JonruAlveus
Copy link
Collaborator

Too many of these to make it worthwhile!

@nickfloyd nickfloyd added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed category: housekeeping labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

No branches or pull requests

3 participants