Review request of teams is not supported

[ch1seL]

Pull request entity of GitHub API contains requested_teams property with an array of team slugs that will be requested but it missed in Octokit.PullRequest entity
Also, Review Requests entity contains similar teams property but Octokit.IPullRequestReviewRequestsClient gets the list of requested users only without teams

[nrukavkov]

+1

[IvanQL]

+1

[LadyGuGa]

+1

[nkirsanov]

+1

[AlexandraKim]

+1

[dbeylkhanov]

+1

[shiftkey]

Also, Review Requests entity contains similar teams property but Octokit.IPullRequestReviewRequestsClient gets the list of requested users only without teams

I think this the APIs as currently implemented are not designed to match the response returned from the GitHub API:

GET /repos/:owner/:repo/pulls/:pull_number/requested_reviewers

{
  "users": [
    {
      "login": "octocat",
      "id": 1,
      "node_id": "MDQ6VXNlcjE=",
      "avatar_url": "https://github.com/images/error/octocat_happy.gif",
      "gravatar_id": "",
      "url": "https://api.github.com/users/octocat",
      "html_url": "https://github.com/octocat",
      "followers_url": "https://api.github.com/users/octocat/followers",
      "following_url": "https://api.github.com/users/octocat/following{/other_user}",
      "gists_url": "https://api.github.com/users/octocat/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/octocat/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/octocat/subscriptions",
      "organizations_url": "https://api.github.com/users/octocat/orgs",
      "repos_url": "https://api.github.com/users/octocat/repos",
      "events_url": "https://api.github.com/users/octocat/events{/privacy}",
      "received_events_url": "https://api.github.com/users/octocat/received_events",
      "type": "User",
      "site_admin": false
    }
  ],
  "teams": [
    {
      "id": 1,
      "node_id": "MDQ6VGVhbTE=",
      "url": "https://api.github.com/teams/1",
      "html_url": "https://api.github.com/teams/justice-league",
      "name": "Justice League",
      "slug": "justice-league",
      "description": "A great team.",
      "privacy": "closed",
      "permission": "admin",
      "members_url": "https://api.github.com/teams/1/members{/member}",
      "repositories_url": "https://api.github.com/teams/1/repos",
      "parent": null
    }
  ]
}

I'm going to drop the up-for-grabs here as there's a bit we need to do here:

• confirm the current client doesn't deserialize correctly
• add unit and integration tests for the correct API
• figure out the right implementation for receiving users and teams
• figure out how to gracefully deprecate the current API