Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer Languages are missing #2030

Closed
Dagizmo opened this issue Oct 15, 2019 · 2 comments
Closed

Newer Languages are missing #2030

Dagizmo opened this issue Oct 15, 2019 · 2 comments
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@Dagizmo
Copy link
Contributor

Dagizmo commented Oct 15, 2019

Acording to this list :
https://github.com/github/linguist/blob/master/lib/linguist/languages.yml

those are the languages in github.

On ocktokit serveral are missing such as "Jupyter Notebooks", how can more languages be added? since currently is only a enum but i don't know if it affects other parts.

@shiftkey
Copy link
Member

shiftkey commented Nov 18, 2019

I have an idea for keeping this in sync, but it requires some work to be more than a band-aid solution here:

  • add linguist as a submodule
  • write a script to check the list against the Languages enum, and identify any values that should be added or removed

public enum Language
{
#pragma warning disable 1591
[SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Abap")]
Abap,
[Parameter(Value = "ActionScript")]
ActionScript,
Ada,
Apex,
[Parameter(Value = "AppleScript")]
AppleScript,
Arc,
[SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Arduino")]
Arduino,
[SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Conf")]
[Parameter(Value = "ApacheConf")]

  • write an Action to periodically
    • update the submodule
    • run the script that verifies the list
    • open a PR with the result and what a reviewer needs to do to manually address the issue

I think there's some extra work here (it'd be great for CI to also verify this) but for now I think this is a decent first step.

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Stale label Jun 8, 2022
@nickfloyd nickfloyd added Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone and removed Stale labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants