Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or Update Team's Repository - missing permission parameter #1320

Closed
ryangribble opened this issue May 24, 2016 · 3 comments
Closed

Add or Update Team's Repository - missing permission parameter #1320

ryangribble opened this issue May 24, 2016 · 3 comments

Comments

@ryangribble
Copy link
Contributor

Related to the Organisation/Team permission changes from last year

When adding/updating a team's access to a repository, there is a permission parameter to control the level of access, we are currently not setting this.

In octokit this should be implemented as a request model object (eg TeamRepositoryUpdate) and an overload added to the I(Observable)TeamsClient interfaces .AddRepository() method

Other issues related to the changes introduced in that GitHub change:
#1319 Missing permissions attribute on #repository collaborators and team's repositories calls
#1101 Add a user as collaborator with permission parameter

@martinscholz83
Copy link
Contributor

martinscholz83 commented Jun 6, 2016

Hi @ryangribble, is there any option to try this out. Because i dont have access to github enterprise. And second question, is there someone still working on this issue?

@ryangribble
Copy link
Contributor Author

This one doesn't require GitHub Enterprise (i take it you already realised that based on the strikethrough text)

I recently pushed up #1342 which addresses #1319, but I haven't done anything on this issue yet, so feel free to take this if you want!

@martinscholz83
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants