Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Signature Verification When Viewing Git Data Commit #1254

Closed
shiftkey opened this issue Apr 7, 2016 · 1 comment
Closed

Get Signature Verification When Viewing Git Data Commit #1254

shiftkey opened this issue Apr 7, 2016 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

shiftkey commented Apr 7, 2016

API documentation: https://developer.github.com/v3/git/commits/#commit-signature-verification

An enhancement as part of the Commit Signing API is to surface the signature details in the commit.

It looks like these are the new properties:

    "verification": {
      "verified": true,
      "reason": "valid",
      "signature": "-----BEGIN PGP MESSAGE-----\n...\n-----END PGP MESSAGE-----",
      "payload": "tree 6dcb09b5b57875f334f61aebed695e2e4193db5e\n..."
    }

These fields should be available on the Commit response object (perhaps in a class called Verification or something), and the CommitsClient.Get action should be updated to use the new Accepts header:

application/vnd.github.cryptographer-preview+sha

I'd also like to see a new integration test added to verify this behaviour is working as expected.

Questions

We use Commit in many places, so I hope that this doesn't affect other places where we deserialize the payload...

@shiftkey shiftkey changed the title Get Commit Signature Verification When Viewing Commit Get Commit Signature Verification When Viewing Git Data Commit Apr 7, 2016
@shiftkey shiftkey changed the title Get Commit Signature Verification When Viewing Git Data Commit Get Signature Verification When Viewing Git Data Commit Apr 7, 2016
@Sarmad93
Copy link
Contributor

@shiftkey i want to grab this one 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

3 participants