Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiOption overloads to methods on IStarredClient #1180

Closed
10 tasks
shiftkey opened this issue Mar 14, 2016 · 1 comment
Closed
10 tasks

Add ApiOption overloads to methods on IStarredClient #1180

shiftkey opened this issue Mar 14, 2016 · 1 comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@shiftkey
Copy link
Member

As part of completing #760 a number of overloads need to be added to the client interfaces.

As an example, this has been added to IReleasesClientand IObservableReleasesClient.

The checklist for porting each method is:

  • Add an overload for this method on IStarredClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IStarredClient
  • Add an overload for this method on IObservableStarredClient with a new parameter ApiOptions
  • Implement the new method on the class which implements IObservableStarredClient

This needs to be done for each of these methods:

  • Task<IReadOnlyList<Repository>> GetAllForCurrent()
  • Task<IReadOnlyList<Repository>> GetAllForCurrent(StarredRequest request)
  • Task<IReadOnlyList<RepositoryStar>> GetAllForCurrentWithTimestamps()
  • Task<IReadOnlyList<RepositoryStar>> GetAllForCurrentWithTimestamps(StarredRequest request)
  • Task<IReadOnlyList<Repository>> GetAllForUser(String user)
  • Task<IReadOnlyList<Repository>> GetAllForUser(String user, StarredRequest request)
  • Task<IReadOnlyList<RepositoryStar>> GetAllForUserWithTimestamps(String user)
  • Task<IReadOnlyList<RepositoryStar>> GetAllForUserWithTimestamps(String user, StarredRequest request)
  • Task<IReadOnlyList<User>> GetAllStargazers(String owner, String name)
  • Task<IReadOnlyList<UserStar>> GetAllStargazersWithTimestamps(String owner, String name)
@shiftkey shiftkey added this to the Pagination Support milestone Mar 14, 2016
@shiftkey
Copy link
Member Author

shiftkey commented Jun 2, 2016

This was fixed in #1336

@shiftkey shiftkey closed this as completed Jun 2, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants