Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository Contents API doesn't support Base64 content directly #1143

Closed
shiftkey opened this issue Mar 11, 2016 · 2 comments · Fixed by #1488
Closed

Repository Contents API doesn't support Base64 content directly #1143

shiftkey opened this issue Mar 11, 2016 · 2 comments · Fixed by #1488
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@shiftkey
Copy link
Member

As raised in #925, we're making the assumption here that you're interested in publishing a UTF-8 string as your content when you create or update a file. That's not entirely true.

As raised in #925 there's a workaround which is to use the Git Data API - see sample here #925 (comment) - but I'll leave this open to indicate an area where we don't currently support it.

@laedit
Copy link
Contributor

laedit commented Oct 4, 2016

If that's ok I want to contribute on this one.

About how to do it, I think that the simplest is to add an EncodingType Encoding property, potentially add the corresponding constructors and remove the SerializeAsBase64 attribute on Content property.

And if you want to avoid any breaking change on this, deal with the base64 in the existing constructors.

What do you think?

@shiftkey
Copy link
Member Author

shiftkey commented Oct 4, 2016

@laedit go for it - there might be some things to catch when serializing/deserialzing but I'm happy to review things and ensure a smooth transition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants