Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGitHubClient.GitDatabase -> IGitHubClient.Git #1037

Closed
shiftkey opened this issue Dec 23, 2015 · 7 comments
Closed

IGitHubClient.GitDatabase -> IGitHubClient.Git #1037

shiftkey opened this issue Dec 23, 2015 · 7 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Milestone

Comments

@shiftkey
Copy link
Member

We should align this API with the documentation:

https://developer.github.com/v3/git/

var commit = await github.GitDatabase.Blob.Get("octokit", "octokit.net", sha);

We should mark this property as obsolete and introduce a new property which is abbreviated:

var commit = await github.Git.Blob.Get("octokit", "octokit.net", sha);
@shiftkey shiftkey added this to the API Cleanup milestone Dec 23, 2015
@shiftkey
Copy link
Member Author

Or should we name this GitData to match with the section header?

@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 23, 2015

Has this been an issue before (conflict of endpoint name in API and section header?)
If there is no precedence, my feeling is to stick with the actual api

@shiftkey
Copy link
Member Author

Has this been an issue before (conflict of endpoint name in API and section header?)

No, just me thinking out loud.

@RobPethick
Copy link

I'll take this. And implement as Git as I think matching the API is best.

@M-Zuber
Copy link
Contributor

M-Zuber commented Dec 24, 2015

Glad someone agrees with me ;)

@elbaloo
Copy link
Contributor

elbaloo commented Jan 15, 2016

This can be closed.

@haacked
Copy link
Contributor

haacked commented Jan 15, 2016

Thanks!

@haacked haacked closed this as completed Jan 15, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

6 participants