Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGitHubClient.Release -> IRepositoriesClient.Release #1032

Closed
shiftkey opened this issue Dec 23, 2015 · 3 comments
Closed

IGitHubClient.Release -> IRepositoriesClient.Release #1032

shiftkey opened this issue Dec 23, 2015 · 3 comments
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Milestone

Comments

@shiftkey
Copy link
Member

This is currently defined as a top-level property, but is documented under /repos/releases in the API:

https://developer.github.com/v3/repos/releases/

var releases = await github.Releases.GetAll("octokit", "octokit.net");

We should mark the top-level property as obsolete and move this under IRepositoriesClient:

var releases = await github.Repository.Releases.GetAll("octokit", "octokit.net");
@shiftkey shiftkey modified the milestone: API Cleanup Dec 23, 2015
@RobPethick
Copy link

I'd like to work on this one

@ryangribble
Copy link
Contributor

Just going through open issues and noticed this one was fixed in #1058 and should be closed

@shiftkey
Copy link
Member Author

shiftkey commented Feb 1, 2016

Whoops! The auto-closing of PRs didn't catch this one. Done!

@shiftkey shiftkey closed this as completed Feb 1, 2016
@nickfloyd nickfloyd added Status: Up for grabs Issues that are ready to be worked on by anyone and removed up-for-grabs labels Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

4 participants