diff --git a/Octokit.Reactive/IObservableGitHubClient.cs b/Octokit.Reactive/IObservableGitHubClient.cs index 2b2cb50b3e..9f1875224a 100644 --- a/Octokit.Reactive/IObservableGitHubClient.cs +++ b/Octokit.Reactive/IObservableGitHubClient.cs @@ -15,7 +15,7 @@ public interface IObservableGitHubClient : IApiInfoProvider /// /// The Timeout value void SetRequestTimeout(TimeSpan timeout); - + IObservableAuthorizationsClient Authorization { get; } IObservableActivitiesClient Activity { get; } IObservableIssuesClient Issue { get; } diff --git a/Octokit.Reactive/ObservableGitHubClient.cs b/Octokit.Reactive/ObservableGitHubClient.cs index 87dc1705f2..11cba00e31 100644 --- a/Octokit.Reactive/ObservableGitHubClient.cs +++ b/Octokit.Reactive/ObservableGitHubClient.cs @@ -64,7 +64,6 @@ public IConnection Connection /// The Timeout value public void SetRequestTimeout(TimeSpan timeout) { - _gitHubClient.SetRequestTimeout(timeout); } diff --git a/Octokit/IGitHubClient.cs b/Octokit/IGitHubClient.cs index e411dc0cdc..1a66aa446b 100644 --- a/Octokit/IGitHubClient.cs +++ b/Octokit/IGitHubClient.cs @@ -16,7 +16,7 @@ public interface IGitHubClient : IApiInfoProvider /// /// The Timeout value void SetRequestTimeout(TimeSpan timeout); - + /// /// Provides a client connection to make rest requests to HTTP endpoints. /// diff --git a/ReleaseNotes.md b/ReleaseNotes.md index b411b6d37a..a648034b97 100644 --- a/ReleaseNotes.md +++ b/ReleaseNotes.md @@ -1,3 +1,23 @@ +### New in 0.28.0 (released 6/11/2017) + +## Advisories and Breaking Changes + +- This release has been pushed out in response to `CommitStatus.Id` on GitHub exceeding `Int32.MaxValue`. We've made this field a `long` now... sorry about that! + +## Release Notes + +**Features/Enhancements** + +- You can now use `IGitHubClient.SetRequestTimeout(TimeSpan timeout)` to set a custom timeout, particularly useful for lengthy operations such as uploading release assets. - [#1693](https://github.com/octokit/octokit.net/pull/1693) via [@pmiossec](https://github.com/pmiossec), [@ryangribble](https://github.com/ryangribble) + +**Fixes** + +- Update `CommitStatus.Id` field from `int` to `long` to prevent overflow exceptions - [#1703](https://github.com/octokit/octokit.net/pull/1703) via [@kzu](https://github.com/kzu) + +**Housekeeping** + +- Correct rendering of `HttpClient` documentation page - [#1699](https://github.com/octokit/octokit.net/pull/1699) via [@scovetta](https://github.com/scovetta) + ### New in 0.27.0 (released 7/10/2017) ## Advisories and Breaking Changes