-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (README): Replace Pika CDN with Skypack CDN #217
Conversation
Replaced "cdn.pika.dev" with "cdn.skypack.dev" in README
@wolfy1339 can you please review my PR I see there is one failing check. Could you please tell me where I went wrong? |
Hey @yash2189, 👋 Your PR looks great! Remember to update the commit title and not leave it as the value GitHub auto-fills. It should be something short and descriptive of all the changes. Then in the body you can explain in detail the changes and the reasoning and link to relevant issues. The checks all look good to me, the ones relevant to you are all good and passing. Thanks for the PR |
Hello @wolfy1339. Apologies I forgot to update the same. I will keep that in mind next time. Will this PR be accepted? |
Of course! It will get merged shortly with all the others |
Congratulations 🥳 We hope you enjoyed the process of sending the pull requests, and maybe learned a thing or two? If anything was unclear, or if you have any suggestions on how we can improve the suggestions in the issue #123, please let us know! It will help future first time contributors! If you are looking to make another pull requests, look out for issues with the help wanted label. They are not as straight forward as the first-timers-only issues, but hey, you no longer are a first-timers 🙂 You can find help wanted issues here. You can help us by starring this repository, as well as our primary repository at https://github.com/octokit/rest.js/ ⭐️ Stars help others to discover our project. If you are interested in Octokit and future opportunities to contribute, you can subscribe to our announcement discussion at https://github.com/octokit/rest.js/discussions/620. We will post an update soon and will point out issues you can contribute to. |
🎉 This issue has been resolved in version 6.0.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #216
View rendered README.md