Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (README): Replace Pika CDN with Skypack CDN #217

Closed
wants to merge 1 commit into from
Closed

fix (README): Replace Pika CDN with Skypack CDN #217

wants to merge 1 commit into from

Conversation

yash2189
Copy link

@yash2189 yash2189 commented Oct 17, 2020

Fixes #216

  • Replaced "cdn.pika.dev" with "cdn.skypack.dev" in README

View rendered README.md

Replaced "cdn.pika.dev" with "cdn.skypack.dev" in README
@yash2189
Copy link
Author

yash2189 commented Oct 17, 2020

@wolfy1339 can you please review my PR I see there is one failing check. Could you please tell me where I went wrong?

@wolfy1339 wolfy1339 added documentation Type: Bug Something isn't working as documented labels Oct 17, 2020
@wolfy1339 wolfy1339 changed the title Update README.md fix (README): Replace Pika CDN with Skypack CDN Oct 17, 2020
@wolfy1339
Copy link
Member

Hey @yash2189, 👋

Your PR looks great!

Remember to update the commit title and not leave it as the value GitHub auto-fills. It should be something short and descriptive of all the changes.

Then in the body you can explain in detail the changes and the reasoning and link to relevant issues.

The checks all look good to me, the ones relevant to you are all good and passing.

Thanks for the PR

@yash2189
Copy link
Author

yash2189 commented Oct 17, 2020

Hello @wolfy1339. Apologies I forgot to update the same. I will keep that in mind next time. Will this PR be accepted?

@wolfy1339
Copy link
Member

Of course! It will get merged shortly with all the others

@gr2m
Copy link
Contributor

gr2m commented Nov 1, 2020

Congratulations 🥳 We hope you enjoyed the process of sending the pull requests, and maybe learned a thing or two? If anything was unclear, or if you have any suggestions on how we can improve the suggestions in the issue #123, please let us know! It will help future first time contributors!

If you are looking to make another pull requests, look out for issues with the help wanted label. They are not as straight forward as the first-timers-only issues, but hey, you no longer are a first-timers 🙂 You can find help wanted issues here.

You can help us by starring this repository, as well as our primary repository at https://github.com/octokit/rest.js/ ⭐️ Stars help others to discover our project.

If you are interested in Octokit and future opportunities to contribute, you can subscribe to our announcement discussion at https://github.com/octokit/rest.js/discussions/620. We will post an update soon and will point out issues you can contribute to.

@gr2m gr2m closed this in 66df8c5 Nov 1, 2020
@github-actions
Copy link

github-actions bot commented Nov 1, 2020

🎉 This issue has been resolved in version 6.0.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "cdn.pika.dev" with "cdn.skypack.dev" in README
3 participants