Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode URL parameters for :placeholder syntax #210

Merged
merged 4 commits into from
Oct 5, 2020
Merged

fix: encode URL parameters for :placeholder syntax #210

merged 4 commits into from
Oct 5, 2020

Conversation

romanbalayan
Copy link
Contributor

Added test case and fix for #207

@gr2m gr2m added the Type: Bug Something isn't working as documented label Oct 5, 2020
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks a lot 👍🏼

@gr2m gr2m changed the title Feat fix url parameter encoding fix: encode URL parameters for :placeholder syntax Oct 5, 2020
@gr2m gr2m merged commit 0e84bb2 into octokit:master Oct 5, 2020
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

🎉 This PR is included in version 6.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@romanbalayan romanbalayan deleted the feat-fix-url-parameter-encoding branch October 13, 2020 13:37
@romanbalayan
Copy link
Contributor Author

Hi @gr2m

I'm currently participating in the hacktoberfest event organized by Digital Ocean, hopefully it won't be too much of a bother for you to add the hacktoberfest-accepted label to this PR so it may be counted towards my progress.

Thank you!

@gr2m
Copy link
Contributor

gr2m commented Oct 13, 2020

of course, done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants