Filter out undefined query parameters and headers #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
force-pushed
the
fix-undefined-param
branch
from
a082d5b to
a4e4d47
Compare
frangio
changed the title
gr2m
reviewed
Oct 4, 2020
gr2m
approved these changes
Oct 5, 2020
|
🎉 This PR is included in version 6.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #206
I initially filtered out undefined query parameters in
add-query-parameters.ts, but then I realized that undefined headers were also being erroneously included. To fix both of those I made it so that undefined values are removed from the options passed by the user before merging.