Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add @octokit/core as peer dependency #53

Closed
gr2m opened this issue Sep 22, 2020 · 0 comments
Closed

add @octokit/core as peer dependency #53

gr2m opened this issue Sep 22, 2020 · 0 comments
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@gr2m
Copy link
Contributor

gr2m commented Sep 22, 2020

See octokit/plugin-paginate-rest.js#124 (comment)

Add

  "peerDependencies": {
    "@octokit/core": ">=3"
  },

to package.json if the project is an Octokit plugin
@gr2m gr2m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 22, 2020
@oscard0m oscard0m mentioned this issue Oct 11, 2020
Closed
@gr2m gr2m closed this as completed Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): add @octokit/core >= 3 as peerDependency
1 participant
@gr2m