Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued closures were deprecated in L5.3 #425

Closed
scottbedard opened this issue Dec 23, 2019 · 3 comments
Closed

Queued closures were deprecated in L5.3 #425

scottbedard opened this issue Dec 23, 2019 · 3 comments

Comments

@scottbedard
Copy link
Contributor

Our documentation appears to be out of date with regard to queueing closures.
https://octobercms.com/docs/services/queues#queueing-closures

This functionality was removed in L5.3, and appears to have been restored in L6
https://laravel.com/docs/5.3/upgrade#upgrade-5.3.0
https://laravel.com/docs/6.x/queues#queueing-closures

We should probably leave a note in the docs saying that this is no longer supported, but likely will be again when the L6 upgrade lands

@daftspunk
Copy link
Member

It's been there for years and nobody has seemed to notice, it should be OK to leave it for another couple of weeks (months?) while we upgrade L6. This is certainly some more incentive to do that

@LukeTowers
Copy link
Contributor

Note this was added back in 5.7 (laravel/framework@556b948 & laravel/framework#25777).

@daftspunk
Copy link
Member

The docs are now referring to an L6 build so we can close this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants