-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow 'observables' in attributes #964
Comments
Thanks Jeremy, late comment but we are going down this path that you suggest. |
I'll sort it out as I dig in. I might just close both when this is resolve. |
This was referenced Mar 10, 2024
@query-jeremy : This will work now and be properly validated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
While discussing #960 today, it was raised that altering the type of attributes from
string_t
orint_t
to more specific types likeuser_agent_t
is a breaking change.We could wait until the 2.x line to introduce this, or we could break with semver and accept a breaking change in 1.x. But neither of these are desirable.
Proposal
An alternative solution is to add the
observable
property to attributes. Currently, only types and objects support theobservable
property.This could be defined in any event, object, or dictionary.
Example:
Upside
Downside
The text was updated successfully, but these errors were encountered: